Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Make ubuntu22 produce build.tgz and execute ci/benchmark.sh #375

Closed
wants to merge 2 commits into from

Conversation

awelzel
Copy link
Contributor

@awelzel awelzel commented Sep 14, 2023

Seems removal happened with fd0dd67.

@awelzel
Copy link
Contributor Author

awelzel commented Sep 14, 2023

@Neverlord - I'm re-working the zeek-benchmarker code base and attempted to re-enabled the broker benchmark tests with this PR. However, broker-cluster-benchmark is expected to be available, but that appears to have been commented out for quite a bit.

# add_executable(broker-cluster-benchmark benchmark/broker-cluster-benchmark.cc)
# target_link_libraries(broker-cluster-benchmark ${libbroker} CAF::core CAF::openssl CAF::io)
# install(TARGETS broker-cluster-benchmark DESTINATION bin)

I wanted to use that for testing to ensure nothing is breaking.. however, given there haven't been any benchmark runs for broker since 2022-02-06 that's becoming a bit modd.

I uncommenting, but the build spills a few thousand lines of c++/caf errors, so maybe a ticket to resurrect broker-cluster-benchmark is easiest?

(cc @timwoj )

@Neverlord
Copy link
Member

@awelzel that broke back when we've implemented the new network layer. I'll pick this up when the variant is ready to test.

@awelzel
Copy link
Contributor Author

awelzel commented Oct 10, 2023

Closing after creating #378 .

@awelzel awelzel closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants