Prepare code for submission to MELPA #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timwoj
changed the title
We're not requiring c-mode to be loaded, so this variable won't be defined. We don't want to load all of c-mode just for this one variable either.
This reverses checking for when before defining the functions to instead putting the when condition inside the function body. I grepped around the el files that come with emacs and this appears to be the standard form. This also fixes some of the function comments to include the argument names like they should.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the code in line with the guidance for submitting new packages to MELPA. This includes:
M-x checkdocM-x flycheck-compileThis all follows the MELPA Contributors Guide. Once this gets nerged, I'll open a pull request to MELPA to add it as a package.