[WIP] Introduce barrier type
#1373
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just the main type scaffolding, most of the actually barrier functionality (i.e., the methods) isn't implemented yet.
We test it by sending bi-directional batch input into spicy-driver, which we then parse with two units synchronizing on a joint barrier. To make this work, `spicy-driver` learns to attempt resuming parsing on the opposite side of a connection if that one currently blocked at a barrier, in case the current data released that barrier. The Zeek plugin will receive a similar change as `spicy-driver`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
barriertypes provides a synchronization point for multiple parsing streams, such as the two sides of a connection. It comes with an expected numberNof parties to reach the synchronization point. Each party must callarrive()to signal it has done so. Each party may callwait()to block until all parties have arrived.This remains experimental for now, feedback welcome. The Zeek plugin still needs to be adapted for this.
This will close #1328.