Fix namespacing of hilti IDs in Spicy-side diagnostic output.
#1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbannier
previously approved these changes
Oct 18, 2024
rsmmr
force-pushed
the
topic/robin/gh-1803-no-hilti
branch
from
9f088ca
to
4ebb7c9
Compare
Because IDs are no longer AST nodes, we did not have a way for a compiler plugin's printing code to modify how it would like them to be printed. This adds a corresponding hook. It's not used anywhere yet, but will be soon. In addition, we add a notion of "user-visibility" to the printer API so that printing code knows whether the resulting output is something that will be shown to the user (e.g., in diagnostics), or remains internal (e..g, raw code output, debugging output). Likewise not used yet, but will be soon. We also clean up the printer API a little bit.
We now show them with a `spicy` prefix, which makes more sense for users. Closes #1803.
rsmmr
force-pushed
the
topic/robin/gh-1803-no-hilti
branch
from
4ebb7c9
to
a76f920
Compare
bbannier
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix namespacing of
hiltiIDs in Spicy-side diagnostic output.We now show them with a
spicyprefix, which makes more sense forusers.
This is a bit messy because our printer code (1) isn't aware of the
HILTI/Spicy distinction; (2) isn't differentiating between output
that's user-visible vs not; and (3) manages its current
parameterization a bit awkwardly through global state. So this
shoehorns a notion of user-visibility in there, and enables the Spicy
plugin to replace
hilti::withspicy::when it deems thatnecessary. Eventually we should overhaul the printer code to be more
modular and contextual.
hiltiIDs in Spicy-side diagnostic output.