Use enums for settings in SRAM header #2429
Open
+65
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fig02
reviewed
Jan 18, 2025
| /* 0x00 */ SRAM_HEADER_SOUND, | ||
| /* 0x01 */ SRAM_HEADER_ZTARGET, | ||
| /* 0x00 */ SRAM_HEADER_AUDIO, |
There was a problem hiding this comment.
it was previously called "sound" because that is what it is called in file select. And the options in the sram header correspond directly with the options in file select.
Currently thinking it makes sense to stay aligned with file select, but more thoughts welcome
There was a problem hiding this comment.
I'd like to rename gSaveContext.audioSetting and AudioSetting too then. What should we call those? And what about what is now SoundMode?
There was a problem hiding this comment.
good question. would like to get @engineer124 involved if he sees this. will put some thought into it in the meantime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put the
AudioSettingenum in z64audio.h since it's used in audio code, but confusingly there's also theSoundModeenum which is almost the same but isn't. I named the function that translates between them asAudio_SetAudioSettingbut this name feels doubly redundant. Suggestions welcome