Use enums for settings in SRAM header

[cadmic]

I put the AudioSetting enum in z64audio.h since it's used in audio code, but confusingly there's also the SoundMode enum which is almost the same but isn't. I named the function that translates between them as Audio_SetAudioSetting but this name feels doubly redundant. Suggestions welcome

[fig02]

it was previously called "sound" because that is what it is called in file select. And the options in the sram header correspond directly with the options in file select.
Currently thinking it makes sense to stay aligned with file select, but more thoughts welcome

[cadmic]

I'd like to rename gSaveContext.audioSetting and AudioSetting too then. What should we call those? And what about what is now SoundMode?

[fig02]

good question. would like to get @engineer124 involved if he sees this. will put some thought into it in the meantime

[fig02]

coming back to this, I think I would be okay with SoundSetting for the file select-side value, and SoundMode for the internal value.
Its not perfect but we can just do that for now and get this moving

[cadmic]

sound good thanks, I updated the PR with that (pending bss fixes)

[fig02]

fwiw I think the SoundSetting enum probably makes more sense in a game-side header, since the value doesnt mean too much to the audio system (other than when it does the translation in Audio_SetSoundMode)

But we can reorganize later. Merging soon

[cadmic]

hm I thought the audio library was supposed to be self-contained though

[Dragorn421]

func_800F6700/Audio_SetSoundMode isn't part of the audio library/driver but part of the game specific audio code, which is indeed mostly self contained but afaik doesn't "have to"?

[fig02]

Right, the value has meaning in save context and file select. Seems to me like it should live in save.h. The audio system doesnt care about the setting value except for that one translation layer function

[fig02]

build failed again