[iQue] Match z_message

[cadmic]

The big clue was that the debug string

"HI_SCORE( kanfont->mbuff.nes_mes_buf[message->rdp] & 0xff000000 ) = %x\n"

was changed to

"HI_SCORE( ((unsigned char*)(kanfont->mbuff.nes_mes_buf))[message->rdp] & 0xff000000 ) = %x\n"

so I think they did a find-and-replace everywhere to workaround the EGCS bug. I made macros for msgCtx->msgBufDecoded, msgCtx->msgBufDecodedWide, font->msgBuf, and font->msgBufWide which are kind of annoying to read but maybe not terrible

[AngheloAlf]

I'm a bit confused as to why the new PRINTFs aren't fenced in a version ifdef.
They don't mess up the debug rom?

[cadmic]

The new PRINTFs are in NTSC-only code, so they wouldn't show up in the debug ROM. When matching NTSC we didn't bother to guess what they were (and some of them ended up being subtly different from PAL anyway)

[fig02]

I think the macros as array accesses look goofy THING(p)[i], but dont think theres anything that can really be done about it

[cadmic]

we could also write THING[i], e.g. #define MSG_BUF_DECODED (msgCtx->msgBufDecoded). It's a bit more magical because it requires something named msgCtx in scope, but maybe it looks better?

[cadmic]

Here's how that would look: cadmic@2d9686d

[fig02]

I like it alot more, but would understand if others are hesitant

[cadmic]

I think I like it better too so I made the change

[fig02]

@AngheloAlf pinging incase you want to re-review with the new change

[AngheloAlf]

I slightly prefer the old syntax but it is fine either way