d_t_mole_prohibit OK

[robojumper]

🚫

Yes, for some reason this matches if I include the weak __dt__5dTg_cFv and __vt__5dTg_c symbols. I don't know why these would be included here (since they're unreferenced), and this might break if a similar pattern is observed in other RELs (though easily fixable by giving up on the common dTg_c ancestor. Who knows...)

[elijah-thomas774]

This applies to most pre/do functions. This is due to being passed into commonPack:

/* 802e1500 */
int fBase_c::commonPack(int (fBase_c::*doFunc)(), int (fBase_c::*preFunc)(), void (fBase_c::*postFunc)(MAIN_STATE_e)) {
    MAIN_STATE_e state;

    // Pre Function to setup
    int result = (this->*preFunc)();
    if (result) {
        // Do function to handle current
        result = (this->*doFunc)();
        if (result == NOT_READY) {
            state = WAITING;
        } else if (result == SUCCEEDED) {
            state = SUCCESS;
        } else {
            state = ERROR;
        }
    } else {
        state = CANCELED;
    }

    // Post Function to handle after effects (Allows for retry after waiting)
    (this->*postFunc)(state);
    return result;
}

Similarly actorCreate(), actorPostCreate(), actorExecute() and actorExecuteInEvent() all return the same kind of status

[elijah-thomas774]

Suggested change

	return 1;
	return SUCCEEDED;

[elijah-thomas774]

Suggested change

	return 1;
	return SUCCEEDED;

[elijah-thomas774]

Suggested change

	return 1;
	return SUCCEEDED;