fix: allow multiple global unbinds in KDL config

[timmclean]

Fixes #2354

The keybinding config logic didn't handle the case where there were multiple global unbinds:

keybinds {
    unbind "a"
    unbind "b"
    unbind "c"

    pane {
      unbind "d"
      unbind "e"
    }
}

The unbinds for "b" and "c" are ignored. Note that the unbinds for "d" and "e" both work properly though, so this seems like a bug.

This PR makes a small change to the config parsing logic to handle the case where there are multiple unbind nodes directly under the keybinds node.

It adds a test for the global unbind case, and also adds a test for the case where there are multiple unbind nodes under a particular mode's node within keybinds (a case that was already working but didn't have a test).

[timmclean]

The e2e tests seem to pass when I run them locally. Might be a flaky test issue?

[tlinford]

The e2e tests seem to pass when I run them locally. Might be a flaky test issue?

Yep green after a rerun :)

[rio]

Ran into this today. Any chance of getting this merged?

[r-vdp]

I've been running with this patch for the last couple of weeks and it solves the issue and doesn't seem to cause any issues.

[r-vdp]

@imsnif this patch still works with 0.39 and fixes an important issue with unbinding multiple global keys.

I've been running with this patch for a while now, and it works fine.

Is there any reason not to merge this?

[r-vdp]

@imsnif friendly ping, did you get the chance to review this? Is there any reason not to merge this and solve the bug with multiple global unbinds?

[imsnif]

Hi - I did not have a chance to review this. While I realize you're disappointed at not seeing this merged, please take a look at the amount of open PRs and issues in this repository* and remember that 95%+ of the work in this project falls on one mostly unpaid person: yours truly.

I wish I could give everything the priority it needs, but unfortunately I am a mere mortal. Thanks for your patience.

*And of course these two categories are only a small fraction of the work that needs to be done here...

[r-vdp]

I understand. Sorry for being pushy. I guess that I felt that the PR might have slipped under the radar.

I do appreciate the tremendous work you're doing with zellij and I understand that this must be very time consuming.

So thank you for that and my apologies for the unnecessary pings.