Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
My team maintains a stream processing application that uses Racecar. Recently we learned that a known issue with librdkafka 1.4.0 (confluentinc/librdkafka#2830) negatively impacts the performance of our application. The latest version of rdkafka, 0.10.0, upgrades the gem to use librdkafka 1.5.0. This PR proposes updating Racecar to use rdkafka 0.10.0.
References:
How?
I made the following changes:
racecar.gemspec
to require rdkafka 0.10.0Gemfile.lock
that were generated by runningbin/setup
Testing
I followed the instructions for setting up the Racecar development environment in the README and confirmed (non-dockerized) tests pass locally by running
bundle exec rspec
.Considerations
spec/integration/consumer_spec.rb
tests sometimes fail when I runbundle exec rspec
but they always pass when I runbundle exec rspec spec/integration/consumer_spec.rb
. I observed this on bothmaster
and my branch. I took care to stop and restart the Docker services after each test run.Thanks in advance for your time! 🙇♀️