-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sam3x: spi: missing macro #47
sam3x: spi: missing macro #47
Conversation
Hi @everedero , You need to follow the rules of the repo. See latest commits for guidance. |
@nandojve I tried opening an issue on Zephyr side, but I am not sure I have the right SHA. |
I added the links in the repo docs that point to correct place that mention how to do it, see https://docs.zephyrproject.org/latest/develop/modules.html#submitting-changes-to-modules |
Yeah I did read that and it is still unclear to me, the doc mentions "the pull request number" to be copied in the revision field but I only found my own commit SHA1, I could not find a PR SHA1, and the CI got angry because it is a SHA1 outside of hal_atmel repository. So, I don’t know if I interpreted the doc correctly, but I opened a PR zephyrproject-rtos/zephyr#86299 |
No worries. pdgendt already gave the answer to you : ) BTW, you still need to update hal_atmel/asf/sam/include/sam3x/README Lines 41 to 45 in da76744
|
Add missing SPI_CSR_BITS macro for sam3x variants Signed-off-by: Eve Redero <[email protected]>
77d1776
to
bc348a9
Compare
77d1776
to
0490931
Compare
Hi @everedero , I saw that the update on |
0490931
to
bc348a9
Compare
Thanks, I forgot to push it 😅 |
Add missing SPI_CSR_BITS macro for sam3x variants