Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sam3x: spi: missing macro #47

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

everedero
Copy link
Contributor

Add missing SPI_CSR_BITS macro for sam3x variants

@nandojve
Copy link
Member

Hi @everedero ,

You need to follow the rules of the repo. See latest commits for guidance.
This should have a PR on zephyr side to pick latest changes.

@nandojve nandojve self-assigned this Feb 25, 2025
@nandojve nandojve self-requested a review February 25, 2025 13:32
@everedero
Copy link
Contributor Author

@nandojve I tried opening an issue on Zephyr side, but I am not sure I have the right SHA.
https://github.com/zephyrproject-rtos/zephyr/pull/86299/commits
This whole process is still unclear to me, do you have a precise commit I could you point me to for reference? Thanks!

@nandojve
Copy link
Member

@nandojve I tried opening an issue on Zephyr side, but I am not sure I have the right SHA. https://github.com/zephyrproject-rtos/zephyr/pull/86299/commits This whole process is still unclear to me, do you have a precise commit I could you point me to for reference? Thanks!

I added the links in the repo docs that point to correct place that mention how to do it, see https://docs.zephyrproject.org/latest/develop/modules.html#submitting-changes-to-modules

@everedero
Copy link
Contributor Author

Yeah I did read that and it is still unclear to me, the doc mentions "the pull request number" to be copied in the revision field but I only found my own commit SHA1, I could not find a PR SHA1, and the CI got angry because it is a SHA1 outside of hal_atmel repository. So, I don’t know if I interpreted the doc correctly, but I opened a PR zephyrproject-rtos/zephyr#86299

@nandojve
Copy link
Member

nandojve commented Feb 25, 2025

Yeah I did read that and it is still unclear to me, the doc mentions "the pull request number" to be copied in the revision field but I only found my own commit SHA1, I could not find a PR SHA1, and the CI got angry because it is a SHA1 outside of hal_atmel repository. So, I don’t know if I interpreted the doc correctly, but I opened a PR zephyrproject-rtos/zephyr#86299

No worries. pdgendt already gave the answer to you : )
You need to update the PR as he mentioned.

BTW, you still need to update

Patch Lst:
* Fix TC registers macros
* Fix RSTC registers macros
* Fix PWM registers macros
* Fix SSC registers macros

Add missing SPI_CSR_BITS macro for sam3x variants

Signed-off-by: Eve Redero <[email protected]>
@everedero everedero force-pushed the fix/missing_macro branch 2 times, most recently from 77d1776 to 0490931 Compare February 25, 2025 21:52
@nandojve
Copy link
Member

Hi @everedero ,

I saw that the update on hal_atmel/asf/sam/include/sam3x/README still missing.

@everedero
Copy link
Contributor Author

Thanks, I forgot to push it 😅

@nandojve nandojve merged commit cd0ddbb into zephyrproject-rtos:master Feb 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants