Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add possibility for XBARB #442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lam-borg
Copy link

We are using the xbarb and it would be nice to have this possibility in the upstream repo aswell.
Thanks for considering

@lam-borg
Copy link
Author

Thanks for reviewing and approval!

Now we just need one more with the right to merge it...

Literally one click away!

Copy link
Member

@dleach02 dleach02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lam-borg, please ensure your commit messages are signed. While this is the NXP HAL, we follow the Zephyr contribution guidelines.

Also, you have two commits in this PR for a oneline change so clean up the commits.

include the xbarb driver if configured

Signed-off-by: Mathias Landolt <[email protected]>
@lam-borg
Copy link
Author

lam-borg commented Oct 16, 2024

@dleach02 Thanks for your input; I fixed it accordingly.

  • cleaned up
  • signed off
  • commit message according guidelines

@dleach02
Copy link
Member

@lam-borg just realized that we need a Zephyr side manifest PR to point to this

@lam-borg
Copy link
Author

I made a pull request in zephyr as well: zephyrproject-rtos/zephyr#80225

Anything that i need to add there or here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants