drivers: wifi: nxp: Fix the compilation error on the MIMXRT1170_EVK board with the NXP_88W8987_MURATA_1ZM_M2 WiFi module #489
Conversation
| #if CONFIG_ZEPHYR | ||
| (void)OSA_EventNotifyPost(wm_wifi.wifi_core_task_Handle); | ||
| #ifdef __ZEPHYR__ | ||
| (void)OSA_TaskNotifyPost(wm_wifi.wifi_core_task_Handle); |
There was a problem hiding this comment.
please remove the non-zephyr part and remove #ifdef __ZEPHYR__
There was a problem hiding this comment.
Guess, as this is the original MCUx SDK code, it may contain non-Zephyr bare-metal code.
| @@ -45,6 +45,7 @@ | |||
| #define sdio_d(...) | |||
| #endif /* CONFIG_WIFI_SDIO_DEBUG */ | |||
|
|
|||
| #ifndef __ZEPHYR__ | |||
There was a problem hiding this comment.
if it's not used for zephyr, you can remove it
|
I have removed the non-Zephyr parts and the #ifdef ZEPHYR as requested. Please review the changes. |
|
This time, I've kept the changes to a minimum and removed all unrelated modifications from the previous commits. I look forward to your review and approval. |
…oard with the NXP_88W8987_MURATA_1ZM_M2 WiFi module - Fix the compilation error on the MIMXRT1170_EVK board with the NXP_88W8987_MURATA_1ZM_M2 WiFi module Signed-off-by: Chen Shu <[email protected]>
|
I have resolved the merge conflicts. Please review. If you feel that my code is not optimal, you can refer to my changes and fix this bug in another commit or PR. However, please do not ignore this bug. Thank you very much! |
|
We have sdio driver bringup recently: #512 |
|
I reviewed the changes in #512, but they do not resolve my issue. However, some of the modifications related to 88w8987 are relevant to this issue. This issue mainly involves changes to mcux/middleware/wifi_nxp/wifidriver/wifi-sdio.c. The other modifications are primarily aimed at ensuring the correct usage of the firmware and allowing the code to compile successfully. If you wish, you can incorporate my changes into #512. I have tried to minimize the necessary modifications as much as possible, and the amount of modified code is relatively small. Thank you very much for your review! |
drivers: wifi: nxp: Fix the compilation error on the MIMXRT1170_EVK board with the NXP_88W8987_MURATA_1ZM_M2 WiFi module