-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts: genpinctrl: add TSC pinctrl definition #241
Conversation
43fe89b
to
a769b9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks fine, but please split template changes from the new batch of generated files in a dedicated commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment
generated TSC pin configs Signed-off-by: Arif Balik <[email protected]>
@arifbalik I think @erwango meant split it into different commits, not into different PRs, anyway same result if we merge them in sequence, @erwango how do you want this? |
Ah, my bad, I can put the commit here as well if you like |
If you don't mind, better to keep them under the same PR I think |
add TSC regex to match and generate pin configs Signed-off-by: Arif Balik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I meant same PR but different commits indeed.
Next time, please put commits in logical order (template changes first, then new batch of files). Anyway not blocking, so "approved", thanks.
Added TSC regex to match and generate pin definitions.
I'm not sure if I should also put here the new pinctrl files, but I've run the script and it generates the pins