Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAI pinctrl #254

Merged
merged 2 commits into from
Jan 31, 2025
Merged

SAI pinctrl #254

merged 2 commits into from
Jan 31, 2025

Conversation

yishai1999
Copy link
Contributor

@yishai1999 yishai1999 commented Jan 30, 2025

Added SAI pinctrl nodes
I am planning on writing an SAI I2S driver in zephyr so I need these nodes to be defined.
I'm not sure how to see if I should add more properties (pull-up, push-pull...). So LMK if I'm making some mistake.

BTW, I'm getting the following warnings when running the genpinctrl script:

Unexpected AF format: GPIO_AF2_rf (ip: STM32WL33_gpio_v1_0)                                                                                                                                                 
Skipping unsupported family STM32MP2.                                                                                                                                                                       
Skipping unsupported family STM32U3.                                                                  
Skipping unsupported family STM32WL3.

Added SAI pinctrl definition to generate SAI pinctrl nodes

Signed-off-by: Yishai Jaffe <[email protected]>
Ran genpinctrl.py to generate the SAI pinctrl nodes

Signed-off-by: Yishai Jaffe <[email protected]>
@yishai1999 yishai1999 changed the title Sai pinctrl SAI pinctrl Jan 30, 2025
Copy link
Collaborator

@gautierg-st gautierg-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regex for pin generation looks good to me.
I'm not very familiar with SAI to comment on pin properties but in example project in STM32CubeIDE, there are no pull-ups, or open-drain and speed is low. So I don't think it is necessary to add anything here.

@kartben kartben merged commit 1844935 into zephyrproject-rtos:main Jan 31, 2025
2 checks passed
@yishai1999 yishai1999 deleted the sai-pinctrl branch February 2, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants