Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stm32cube: stm32h7/h5: eth: Fix calculation of the tail pointer #257

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

erwango
Copy link
Member

@erwango erwango commented Jan 31, 2025

Copy link

@pdgendt pdgendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the same patch for all variants (for example, h5 needs the same patch)

Cherry-picking commit ceda3ceeca2ee77a76d2de2ee6b560ad87c90a48
in STM32H7 Cube HAL
https://github.com/STMicroelectronics/stm32h7xx-hal-driver/

Fixed in hal_stm32 main branch following cube version update
from version v1.11.2 to version v1.12.0.

Signed-off-by: Erwan Gouriou <[email protected]>
Fixed in hal_stm32 main branch following cube version update
from version v1.3.0 to version v1.4.0.

Signed-off-by: Erwan Gouriou <[email protected]>
@erwango erwango force-pushed the fix_eth_heavy_load branch from f29bb5f to 5837af2 Compare January 31, 2025 10:48
Remove Python 3.7 and 3.8 from the CI test matrix, as these versions are
deprecated / EOL. This enables usage of Python 3.9+ features in scripts,
such as str.removeprefix/str.removesuffix, and should cause any issue since
the scripts are always executed manually anyways.

Signed-off-by: Mathieu Choplain <[email protected]>
The upload-artifact@v2 action was deprecated since a while, and is now
completely disabled (forceful CI failure). Update to v4 to get CI back.

This also requires changing the artifact names, as the v4 action no
longer supports uploading different artifacts with the same name.

Signed-off-by: Mathieu Choplain <[email protected]>
@erwango erwango changed the title stm32cube: stm32h7: eth: Fix calculation of the tail pointer stm32cube: stm32h7/h5: eth: Fix calculation of the tail pointer Jan 31, 2025
@erwango
Copy link
Member Author

erwango commented Jan 31, 2025

Adding @nashif and @aescolar to the review as v3.7.0 release engineers

Copy link
Member

@aescolar aescolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@erwango
Copy link
Member Author

erwango commented Feb 6, 2025

@aescolar, @nashif Are we expecting something to merge this ?

@nashif
Copy link
Member

nashif commented Feb 6, 2025

@aescolar, @nashif Are we expecting something to merge this ?

someone you mean? Are you not able to merge it yourself?

@erwango
Copy link
Member Author

erwango commented Feb 6, 2025

someone you mean? Are you not able to merge it yourself?

I used to have the rights on the hal_stm32 repo, but I've lost them (for all branches) last week, following the discussion on discord.

@aescolar aescolar merged commit 0657d9f into zephyrproject-rtos:v3.7-branch Feb 6, 2025
2 checks passed
@aescolar
Copy link
Member

aescolar commented Feb 6, 2025

@erwango I just merged it for you, but @nashif or some other admin should give you merge rights again. It is silly otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants