Ethernet: Add stm32n6 pinctrl #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwango
requested changes
Feb 5, 2025
| @@ -144,6 +144,22 @@ | |||
| match: "^ETH_TXD3$" | |||
| slew-rate: very-high-speed | |||
|
|
|||
| - name: ETH | |||
There was a problem hiding this comment.
This might not be obvious why this differs from other ETH filters above.
Maybe you should specify "ETH (STM32N6 IP)", or sort of.
Additionally, it would be nice to squash the other ETH pins into a one liner to help comparing (non-blocking though)
Add STM32N6 Ethernet pinctrl config. Use specific entry for "ETH (STM32N6 IP)" for clarify. Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <[email protected]>
marwaiehm-st
force-pushed
the
add_n6_eth_pinctrl
branch
from
33fe1c3 to
572fb3e
Compare
… entry Combined individual ETH pin configurations into a single entry for better readability and maintainability. Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <[email protected]>
Update STM32N6 pinctrl dtsi files with the ETH pins Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <[email protected]>
marwaiehm-st
force-pushed
the
add_n6_eth_pinctrl
branch
from
572fb3e to
65fe1ab
Compare
erwango
approved these changes
Feb 6, 2025
gautierg-st
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update STM32N6 pinctrl dtsi files with the ETH pins
Add STM32N6 Ethernet pinctrl config to stm32-pinctrl-config.yaml