Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kconfig: Signal newlib support in Kconfig too #626

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

kconfig: Signal newlib support in Kconfig too #626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cmake/zephyr/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,9 @@ config TOOLCHAIN_ZEPHYR_0_16
config TOOLCHAIN_ZEPHYR_SUPPORTS_THREAD_LOCAL_STORAGE
def_bool y
select TOOLCHAIN_SUPPORTS_THREAD_LOCAL_STORAGE

config NEWLIB_SUPPORTED
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think a generic option should be in here. For example how will the arm-gnu-embedded toolchain enable NEWLIB_SUPPORTED. This should be in Zephyr proper and have something like:

config TOOLCHAIN_ZEPHYR_SUPPORTS_NEWLIB`
  def_bool y
  select NEWLIB_SUPPORTED

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or add select NEWLIB_SUPPORTED under config TOOLCHAIN_ZEPHYR_0_16

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already got a proposed patch which does that (no need for the version check, Zephyr SDK has always supported newlib). I was just following the suggestion about where similar mechanism for Picolibc should live, and that will live in sdk-ng. Happy to have it in Zephyr instead; it's a lot easier to manage there anyways.

def_bool y
depends on "$(ZEPHYR_TOOLCHAIN_VARIANT)" = "zephyr"
help
Zephyr always supports newlib for C and C++ development.