samples: modules: thrift: Add newlib filter to samples.yaml #57097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanosio
requested changes
Apr 22, 2023
There was a problem hiding this comment.
Will block this until #54637 is merged since that PR introduces a new way of filtering by full libc availability.
cfriedt
previously approved these changes
Apr 22, 2023
|
Does this test just need |
|
@galak - please revisit the pr mentioned above by Stephanos |
|
@galak - minor changes needed here |
cfriedt
reviewed
May 2, 2023
| @@ -1,12 +1,10 @@ | |||
| # CONFIG_LIB_CPLUSPLUS Dependencies | |||
| CONFIG_NEWLIB_LIBC=y | |||
| CONFIG_NEWLIB_LIBC_NANO=n | |||
| CONFIG_REQUIRES_FULL_LIBCPP=y | |||
There was a problem hiding this comment.
It might even be better to move this to select REQUIRES_FULL_LIBCPP in modules/thrift/Kconfig.
There was a problem hiding this comment.
I wish there were an ISO C code generator upstream (instead of the one that depends on glib)
|
LGTM other than the one suggestion above. Filters are good as well - that will speed up CI. |
stephanosio
reviewed
May 3, 2023
Change sample to set CONFIG_FULL_LIBCPP_REQUIRED and to filter on CONFIG_FULL_LIBCPP_SUPPORTED. Since not all toolchains provide a full libc++ this will restrict the sample only to those environments that do. Signed-off-by: Kumar Gala <[email protected]>
rebased, removed DNM. |
stephanosio
approved these changes
May 3, 2023
keith-packard
approved these changes
May 3, 2023
cfriedt
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all toolchains support newlib so tests that require newlib need to have a filter to we don't try and build those tests on those testcases. Add the following to samples.yaml to handle the issue: