Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: Update hal_nxp to add Wi-Fi driver #79536

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

MaochenWang1
Copy link
Contributor

Update hal_nxp to add Wi-Fi driver code.

@zephyrbot zephyrbot added the size: XS A PR changing only a single line of code label Oct 8, 2024
@zephyrbot
Copy link
Collaborator

zephyrbot commented Oct 8, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@683c007 zephyrproject-rtos/hal_nxp#454 zephyrproject-rtos/hal_nxp#454/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Oct 8, 2024
@dleach02 dleach02 self-assigned this Oct 8, 2024
@bjarki-andreasen bjarki-andreasen dismissed their stale review October 8, 2024 15:44

sorry, bit to quick :)

@bjarki-andreasen
Copy link
Collaborator

looks good, ping when its a sha :)

@dleach02 dleach02 force-pushed the main_mc_update_hal_nxp_416 branch 2 times, most recently from f45f3e2 to a72fb7f Compare October 18, 2024 19:06
dleach02
dleach02 previously approved these changes Oct 18, 2024
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Oct 18, 2024
@dleach02 dleach02 added this to the v4.0.0 milestone Oct 18, 2024
danieldegrasse
danieldegrasse previously approved these changes Oct 18, 2024
@zephyrbot zephyrbot added the DNM This PR should not be merged (Do Not Merge) label Oct 18, 2024
@danieldegrasse
Copy link
Collaborator

Updated this PR with the contents of #80082, as the WiFi driver was previously not building in CI (and did not build without the changes now applied to this PR)

@@ -15,7 +15,7 @@
!defined(CONFIG_EAP_PSK) && !defined(CONFIG_EAP_PAX) && \
!defined(CONFIG_EAP_SAKE) && !defined(CONFIG_EAP_GPSK) && \
!defined(CONFIG_EAP_PWD) && !defined(CONFIG_EAP_EKE) && \
!defined(CONFIG_EAP_IKEV2 && !defined(CONFIG_EAP_GTC)
!defined(CONFIG_EAP_IKEV2) && !defined(CONFIG_EAP_GTC)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fixed by de54470

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jukkar how do you want deal with this? Merge this and abandon that PR or wait for it to be merged and rebase this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should let the other PR still move forward. @jukkar PR is needed to add the test case going forward.

modules/hostap/src/supp_main.c Show resolved Hide resolved
modules/hostap/src/supp_main.c Show resolved Hide resolved
@@ -75,33 +75,6 @@ CONFIG_NET_SOCKETS_SERVICE_THREAD_PRIO=3
CONFIG_NET_TC_SKIP_FOR_HIGH_PRIO=y
CONFIG_NET_CONTEXT_PRIORITY=y

CONFIG_WIFI_NM_WPA_SUPPLICANT=y
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but without this will Wi-Fi work on RW612?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this commit

west.yml Show resolved Hide resolved
krish2718
krish2718 previously approved these changes Oct 21, 2024
MaochenWang1 and others added 10 commits October 22, 2024 12:26
Update hal_nxp to add Wi-Fi driver code.

Signed-off-by: Maochen Wang <[email protected]>
Fix a missing stray parenthesis in the conditional within the supplicant
implementation, which was causing a build error for WiFi samples

Signed-off-by: Daniel DeGrasse <[email protected]>
ap_bandwidth API implementation is not complete. Remove the structure
definition and implementation from the NXP WiFi driver to fix a build
error.

Signed-off-by: Daniel DeGrasse <[email protected]>
set_btwt API implementation is not complete. Remove the structure
definition and implementation from the NXP WiFi driver to fix a build
error.

Signed-off-by: Daniel DeGrasse <[email protected]>
Remove references to TWT fields that did not exist, to resolve a build
error.

Signed-off-by: Daniel DeGrasse <[email protected]>
Remove unused function `nxp_wifi_uap_status`.

Signed-off-by: Daniel DeGrasse <[email protected]>
Add CONFIG_NXP_WIFI_BUILD_ONLY_MODE, which allows the NXP WiFi driver to
be built without a binary blob. The built application will not be
functional, but this enables continuous integration to run upstream.

Signed-off-by: Daniel DeGrasse <[email protected]>
Add support for building NXP WiFi. Since the driver typically requires
binary blobs, enable CONFIG_NXP_WIFI_BUILD_ONLY_MODE for this testcase.

Signed-off-by: Daniel DeGrasse <[email protected]>
Fix build error of multiple definition of `dh5_init' in
crypto_mbedtls_alt.c when WPS enabled.

Signed-off-by: Maochen Wang <[email protected]>
Remove CONFIG_MBEDTLS_HAVE_TIME_DATE, which will cause that mbedtls
include Zephyr time.h and leads to 'DIV_ROUND_UP' redefined warning.

Signed-off-by: Maochen Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Networking area: Samples Samples area: Wi-Fi Wi-Fi DNM This PR should not be merged (Do Not Merge) manifest manifest-hal_nxp platform: NXP Drivers NXP Semiconductors, drivers size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants