-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: bluetooth: Rename Silabs HCI driver #80155
base: main
Are you sure you want to change the base?
Conversation
Added the DNM flag, since this actually depends on an update to CMakeLists.txt in the HAL tree. I think it's better to wait for #80148 to be merged first since then it's the main tree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we should rename the slz_
functions before to merge ths PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functions in this file are prefixed with slz_
. Maybe we could rename them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functions in this file are prefixed with
slz_
. Maybe we could rename them?
Those functions are private to the driver, and I was trying to keep this PR as minimal as possible. The names can be changed at any point without affecting anything outside of the driver. What would you like the names to be? (I considered doing the rename but then dropped the idea since I couldn't decide on a nice and short prefix)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I foresee a long discussion. Let's postpone that change.
Rename the Silabs HCI driver to hci_silabs_efr32.c to better indicate what hardware it supports. Also rename the associated devicetree binding and Kconfig options to be consistent with the new driver name. Signed-off-by: Johan Hedberg <[email protected]>
501e175
Rebased now and DNM label removed. |
Rename the Silabs HCI driver to hci_silabs_efr32.c to better indicate what hardware it supports. Also rename the associated devicetree binding and Kconfig options to be consistent with the new driver name.