drivers: pwm: rpi_pico: Convert clk calculations to fixed-point #80257
+5
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the use of floating point to calculate in `pwm_rpi_get_cycles_per_sec` to fixed point calculations that result in the same value. There is still a division here, which is somewhat slow still, but the end result about twice fast for the whole path through the led pwm code. Even better would be to cache these values, since there is no interface in this driver to change the configuration past init time. Signed-off-by: David Brown <[email protected]>
zephyrbot
added
platform: Raspberry Pi Pico
henrikbrixandersen
approved these changes
Oct 22, 2024
ceolin
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the use of floating point to calculate in
pwm_rpi_get_cycles_per_secto fixed point calculations that result in the same value. There is still a division here, which is somewhat slow still, but the end result about twice fast for the whole path through the led pwm code.Even better would be to cache these values, since there is no interface in this driver to change the configuration past init time.