drivers: wm8904: Fix audio input configuration #85736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change erroneous mask in wm8904_volume_config. Extend WM8904_REGVAL_INSEL. Unflip register mask and value parameters. Signed-off-by: Vit Stanicek <[email protected]>
dbaluta
approved these changes
Feb 13, 2025
kartben
approved these changes
Feb 18, 2025
| @@ -102,7 +102,7 @@ | |||
| * [1:0] - x_MODE: Input mode | |||
| */ | |||
| #define WM8904_REGVAL_INSEL(cm, nin, pin, mode) \ | |||
| (((cm) & 0b1) << 6) | (((nin) & 0b11) << 4) | |||
| (((cm) & 0b1) << 6) | (((nin) & 0b11) << 4) | (((pin) & 0b11) << 2) | |||
There was a problem hiding this comment.
Not directly related to your change of course, but binary literals should be avoided in Zephyr
https://docs.zephyrproject.org/latest/contribute/style/code.html
There was a problem hiding this comment.
I think the guideline is a SHOULD, not a MUST, but yeah...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few bugs in the
wm8904codec driver prevent correct audio input configuration, namely input volume and mute settings. Thus change erroneous mask inwm8904_volume_config, extendWM8904_REGVAL_INSELand unflip register mask and value parameters.Related to #77814, marking it as a prerequisite.