-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Horse Animation #2786
Horse Animation #2786
Conversation
🙏 Thanks for your pull request @Yash15-maker, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🥳 Congratulations 🎉Congrats on making your first Pull Request in the Zero To Mastery Organization! ZTM Profile BadgeIf you'd like the ZTM Badge to show up on your profile, you will need to follow this guide! |
🙏 Thanks for your pull request @Yash15-maker, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aloha @Yash15-maker 🙌
Thanks for your contribution 🎉
In order to merge your PR please address the following:
- Please address the given feedbacks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HTML's link tag to adjust
- Once you've changed the css file name according to the readme guidelines, you will need to adjust the href
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSS file name
- Please rename your css file as described in both the readme and the PR's checklist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary picture
- Please remove the picture - a generated icon will be done on merging the PR so there is no need to have the extra file.
🙏 Thanks for your pull request @Yash15-maker, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🙏 Thanks for your pull request @Yash15-maker, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
Sets label to stale : no activity for >= 3 days |
🙏 Thanks for your pull request @Yash15-maker, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
Stalling and no activities in the PR and previously |
Thank you for making a pull request to ZTM's Animation Nation project. We will review your pull request as soon as we can, but keep in mind we can get very busy during Hacktoberfest.
While you're waiting, please look over this checklist. Feel free to write a description of what you did as well!
What I did
Optional: Edit this to tell us what you did!
Pull request checklist
meta.json
file.Yash15-maker-horseAnimation
without the <>.index.html
andstyles.css
.index.html
styles.css
meta.json
with:githubHandle
: being your unique github user name,artName
: name of your animationNot normally needed
Note: if your pull request makes an improvement besides adding a CSS animation you will need to discuss this with the maintainers. You can help kickstart this process by explaining what your change does and why you are making it in the "What I did" section
What to expect