violin87-activeSquares #2791
violin87-activeSquares #2791
Conversation
|
🙏 Thanks for your pull request @violin87, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🥳 Congratulations 🎉Congrats on making your first Pull Request in the Zero To Mastery Organization! ZTM Profile BadgeIf you'd like the ZTM Badge to show up on your profile, you will need to follow this guide! |
|
🙏 Thanks for your pull request @violin87, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @violin87, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
There was a problem hiding this comment.
Aloha bis :) @violin87
Please address the following :
- Please address all the review I already gave you which are rementionned again on this review
- Please add a meta.json
You can read the README.md if you don't know how to
Art/SumitDutta007-bubbles/styles.css
Outdated
There was a problem hiding this comment.
Changes in a folder that does not belong to you
- Please remove any changes in
SumitDutta007-bubblesfolder
There was a problem hiding this comment.
HTML review ( indentation + question )
- Please ensure a correct indentation for your HTML, nested divs are not correctly indented + it can make it hard to double check and it is a bad practice to correct
What is that comment about ?
<!-- I PURCHASED IMAGES -->
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Multiple empty lines to removes
As mentioned in your previous PRs
- Please remove the empty lines
Here is a visual to help you where line 129 - line 146 are empty / so it is for line 152 to 156
|
🙏 Thanks for your pull request @violin87, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @violin87, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
1 similar comment
|
🙏 Thanks for your pull request @violin87, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @violin87, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @violin87, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
Thank you for making a pull request to ZTM's Animation Nation project. We will review your pull request as soon as we can, but keep in mind we can get very busy during Hacktoberfest.
While you're waiting, please look over this checklist. Feel free to write a description of what you did as well!
What I did
Optional: Edit this to tell us what you did!
Pull request checklist
meta.jsonfile.<github_username>-<art_name>without the <>.index.htmlandstyles.css.index.htmlstyles.cssmeta.jsonwith:githubHandle: being your unique github user name,artName: name of your animationNot normally needed
Note: if your pull request makes an improvement besides adding a CSS animation you will need to discuss this with the maintainers. You can help kickstart this process by explaining what your change does and why you are making it in the "What I did" section
What to expect