Use CtrlCHandler in IceStorm/clock (Swift) #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Feb 5, 2025
swift/IceStorm/clock/slice/Clock.ice
Outdated
There was a problem hiding this comment.
I used Greeter as a model. Could we put this slice directory in Sources? I would find it clearer, since the Slice file is a source file.
| } catch { | ||
| print("Error: \(error)\n") | ||
| return 1 | ||
| } | ||
| } | ||
|
|
||
| exit(run()) | ||
| let ctrlCHandler = Ice.CtrlCHandler() | ||
| exit(await run(ctrlCHandler: ctrlCHandler)) |
There was a problem hiding this comment.
I am not fond of this "exit(run)" pattern, we should replace it.
With this pattern, it's critical to create the CtrlCHandler before the first await call.
| do { | ||
| try await clock.tick(dateFormatter.string(from: Date())) | ||
| } catch let error as Ice.LocalException { | ||
| print("tick invocation failed with: \(error.message)") |
There was a problem hiding this comment.
The plain \(error) for a local exception displays the full C++ stack trace. We should double-check that's the desired behavior.
externl
approved these changes
Feb 5, 2025
pepone
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the IceStorm/clock demo to use async/await and the CtrlCHandler.
The focus of this PR is fixing #75. This demo should be reviewed / improved in a follow-up PR.
Fixes #75.