Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Java adapterDeactivation #3034

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Fix Java adapterDeactivation #3034

merged 2 commits into from
Nov 1, 2024

Conversation

externl
Copy link
Member

@externl externl commented Oct 31, 2024 •
edited
Loading

I bumped the sleep time to 1500.

Fixes #2711

@externl externl marked this pull request as draft October 31, 2024 19:54
@externl externl marked this pull request as ready for review November 1, 2024 13:21
bernardnormier
bernardnormier approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@bernardnormier bernardnormier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this doesn't find this occasional CI failure, we should rework the test, not increase this timeout a little more each time.

@externl externl merged commit 5ebaeb9 into zeroc-ice:main Nov 1, 2024
19 checks passed
@externl externl deleted the 2711-java-adapterDeactivation branch November 1, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernardnormier bernardnormier bernardnormier approved these changes

@pepone pepone pepone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ice/adapterDeactivation test failure in Java
3 participants
@externl @pepone @bernardnormier