Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable stack trace collection on Windows/ws for the cpp/Ice/timeout test #3158

Merged
merged 3 commits into from
Nov 16, 2024
Merged

Disable stack trace collection on Windows/ws for the cpp/Ice/timeout test #3158

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5958111
Turn off stack traces on Windows with ws[s]
bernardnormier Nov 15, 2024
5eabf2c
Fix
bernardnormier Nov 15, 2024
addff79
Update comment
bernardnormier Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions cpp/test/Ice/timeout/Server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,21 @@ Server::run(int argc, char** argv)
{
Ice::PropertiesPtr properties = createTestProperties(argc, argv);

//
// The client sends large messages to cause the transport
// buffers to fill up.
//
// The client sends large messages to cause the transport buffers to fill up.
properties->setProperty("Ice.MessageSizeMax", "20000");

//
// Limit the recv buffer size, this test relies on the socket
// send() blocking after sending a given amount of data.
//
// Limit the recv buffer size, this test relies on the socket send() blocking after sending a given amount of data.
properties->setProperty("Ice.TCP.RcvSize", "50000");

#ifdef _WIN32
// Turn off stack trace collection and printing on Windows with ws(s): they slow down the logging so much that this
// test can fail. See #3048.
if (getTestProtocol(properties).find("ws") == 0)
{
properties->setProperty("Ice.PrintStackTraces", "0");
}
#endif

Ice::CommunicatorHolder communicator = initialize(argc, argv, properties);

communicator->getProperties()->setProperty("TestAdapter.Endpoints", getTestEndpoint());
Expand Down