Misc fixes to C# locator discovery #3177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Nov 21, 2024
| @@ -11,11 +11,6 @@ public Ice.Plugin | |||
| create(Ice.Communicator communicator, string name, string[] args) => new PluginI(communicator); | |||
| } | |||
|
|
|||
| public interface Plugin : Ice.Plugin | |||
There was a problem hiding this comment.
We use this (obviously) internal API in C++ and Java, but not in C#, where it's internal unused code.
| { | ||
| while (!_locators.ContainsKey(instanceName) && _pending) | ||
| { | ||
| Monitor.Wait(_mutex, waitTime); |
There was a problem hiding this comment.
The only Monitor.Wait(_mutex, ...), which means all the Monitor.Pulse(_mutex) elsewhere are useless.
| { | ||
| // Exit the mutex lock before proceeding. |
There was a problem hiding this comment.
Awaiting a remote call with a mutex lock (see below) is incorrect and deadlock prone. It could be the cause for #2813.
pepone
approved these changes
Nov 22, 2024
externl
approved these changes
Nov 22, 2024
|
The timer task (and runTimerTask) are used, e.g. _timer.schedule(this, _timeout); |
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple bugs in the C# LocatorDiscovery and removes dead code.
See also #2813.