Fix DataStorm filter initialization #3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
commented
Dec 17, 2024
| @@ -142,7 +142,6 @@ namespace DataStormI | |||
| virtual ~FilterFactory() = default; | |||
|
|
|||
| virtual std::shared_ptr<Filter> get(std::int64_t) const = 0; | |||
| virtual std::shared_ptr<Filter> decode(const Ice::CommunicatorPtr&, const Ice::ByteSeq&) = 0; | |||
There was a problem hiding this comment.
This was never called for a FilterFactoryT. But the implementation was preventing us for passing the name and lambda in the FilterT constructor.
bernardnormier
approved these changes
Dec 17, 2024
externl
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #2926, and replaces #3277