Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Ice.ThreadInterruptSafe #3334

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Remove Ice.ThreadInterruptSafe #3334

merged 2 commits into from
Jan 10, 2025

Conversation

pepone
Copy link
Member

@pepone pepone commented Jan 10, 2025

Fixes #3330

bernardnormier
bernardnormier approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@bernardnormier bernardnormier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, much simpler.

For a follow-up PR: we should check that we want to keep OperationInterruptedException as our unchecked translation for InterruptedException.

java/test/src/main/java/test/Ice/interrupt/AllTests.java
} catch (test.Ice.interrupt.Test.InterruptedException e) {
test(false);
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should revisit this test in a follow-up PR. For example, the code below seems to test Java not Ice, which makes no sense.

java/src/com.zeroc.ice/src/main/java/com/zeroc/Ice/ConnectionI.java Outdated
});
} else {
abortImpl();
synchronized (this) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the check above. abort() is a non-blocking operation.

@pepone pepone merged commit 8857b67 into zeroc-ice:main Jan 10, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernardnormier bernardnormier bernardnormier approved these changes

@externl externl externl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Ice.ThreadInterruptSafe
3 participants
@pepone @externl @bernardnormier