Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix C++ generated code #3425

Merged
merged 2 commits into from
Jan 25, 2025
Merged

Fix C++ generated code #3425

merged 2 commits into from
Jan 25, 2025
+105 −122

Conversation

bernardnormier
Copy link
Member

This PR updates slice2cpp as follows:

  • the generated code for dispatch is now using a std::array instead of a C array
  • we no longer unqualify fixed Ice names such as Ice::Context
  • we no longer put :: in front of fixed Ice names such as Ice::Context and IceInternal::xxx.

pepone
pepone approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@pepone pepone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should we also remove the global :: for std?

@bernardnormier
Copy link
Member Author

Looks good. Should we also remove the global :: for std?

I think we should (in a separate PR). If you use Slice module "std", you should remap it in C++ to some other name.

@bernardnormier bernardnormier merged commit f1927f4 into zeroc-ice:main Jan 25, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@externl externl externl approved these changes

@pepone pepone pepone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bernardnormier @pepone @externl