Normalize IPv6 used in Endpoint.equivalent #3428
Open
+58
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
commented
Jan 25, 2025
pepone
changed the title
bernardnormier
approved these changes
Jan 27, 2025
| @@ -1610,6 +1610,27 @@ IceInternal::getNumericAddress(const std::string& address) | |||
| } | |||
| } | |||
|
|
|||
| string | |||
| IceInternal::normalizeIPv6Address(string_view host) | |||
There was a problem hiding this comment.
I would use a const string& for host since you give it to inet_pton that expects a null-terminated C-string.
| @@ -117,7 +120,7 @@ public override bool equivalent(EndpointI endpoint) | |||
| } | |||
| IPEndpointI ipEndpointI = (IPEndpointI)endpoint; | |||
| return ipEndpointI.type() == type() && | |||
| ipEndpointI.host_.Equals(host_, StringComparison.Ordinal) && | |||
| ipEndpointI._normalizedHost.Equals(_normalizedHost, StringComparison.Ordinal) && | |||
There was a problem hiding this comment.
I would use operator== to compare these strings.
See https://learn.microsoft.com/en-us/dotnet/csharp/how-to/compare-strings.
There was a problem hiding this comment.
Make the intent of your code clear by calling an overload that explicitly specifies the type of comparison to perform.
Isn't that what we do here? Afaik there is a linter rule for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C# and C++, Java was already done see #3154.
I don't think we need to update JavaScript,