Add CtrlCHandler helper class (Swift) #3469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Feb 1, 2025
| /// @param cb The callback function to invoke when a signal is received. | ||
| explicit CtrlCHandler(CtrlCHandlerCallback cb); | ||
|
|
||
| CtrlCHandler(const CtrlCHandler&) = delete; |
There was a problem hiding this comment.
Not having these made the class rather bug-prone.
|
|
||
| @interface ICECtrlCHandler () | ||
| { | ||
| Ice::CtrlCHandler cppObject; |
There was a problem hiding this comment.
It's essential to use a field and not a property here, since a property wants to return a copy of the C++ object (which is not copyable).
|
Although not tested yet, I believe this helper class can also be used when waiting for either Ctrl+C or a shutdown request, with something like: Task {
await ctrlCHandler.catchSignal()
communicator.shutdown() // initiate shutdown after receiving signal
}and the "main" thread blocks on |
pepone
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the CtrlCHandler helper class to Swift.
It's a thin wrapper over the Ice::CtrlCHandler class provided by Ice C++. It's main consumer is our Swift demos for macOS.