Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: iceberg & ttl orders support #60

Merged
merged 6 commits into from
Sep 13, 2023

Conversation

bhumitattarde
Copy link
Collaborator

Closes #48. Test before approving.

@rhnvrm
Copy link
Member

rhnvrm commented Feb 8, 2023

@ranjanrak possible to place orders and test this in the market?

@@ -55,6 +55,7 @@ const string VARIETY_REGULAR = "regular";
const string VARIETY_BO = "bo";
const string VARIETY_CO = "co";
const string VARIETY_AMO = "amo";
const string VERIETY_ICEBERG = "iceberg";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a typo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think the commit (dd7e06b) is showing up so the branch might need to be rebased.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the typo.

That commit is showing up because I had created this branch from previous PR branch (because I needed those changes here). It doesn't matter because I intend to squash the commits.

@bhumitattarde
Copy link
Collaborator Author

@rhnvrm @ranjanrak any update here?

@ranjanrak
Copy link
Member

@bhumitattarde Was checking on this and there are tons of deps to build and run an example file here. It might be helpful to create a simple Docker file with a new example in the examples folder, which can be easily plugged with the API creds for testing and verification purposes. This could simplify the setup process and make it more convenient for reviewing the changes.

@bhumitattarde
Copy link
Collaborator Author

@ranjanrak Done.

@rhnvrm rhnvrm requested a review from ranjanrak August 29, 2023 10:20
@ranjanrak
Copy link
Member

Checked. Everything looks good. I've also added an example for an iceberg TTL order via this PR.

@bhumitattarde bhumitattarde merged commit ee29a56 into zerodha:main Sep 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for iceberg + ttl orders
3 participants