-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: iceberg & ttl orders support #60
feat: iceberg & ttl orders support #60
Conversation
@ranjanrak possible to place orders and test this in the market? |
include/kitepp/userconstants.hpp
Outdated
@@ -55,6 +55,7 @@ const string VARIETY_REGULAR = "regular"; | |||
const string VARIETY_BO = "bo"; | |||
const string VARIETY_CO = "co"; | |||
const string VARIETY_AMO = "amo"; | |||
const string VERIETY_ICEBERG = "iceberg"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be a typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I think the commit (dd7e06b) is showing up so the branch might need to be rebased.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the typo.
That commit is showing up because I had created this branch from previous PR branch (because I needed those changes here). It doesn't matter because I intend to squash the commits.
@rhnvrm @ranjanrak any update here? |
@bhumitattarde Was checking on this and there are tons of deps to build and run an example file here. It might be helpful to create a simple Docker file with a new example in the examples folder, which can be easily plugged with the API creds for testing and verification purposes. This could simplify the setup process and make it more convenient for reviewing the changes. |
@ranjanrak Done. |
Checked. Everything looks good. I've also added an example for an iceberg TTL order via this PR. |
Closes #48. Test before approving.