Merge pull request #18 from zerodha/imdsv2

feat: make http_put_response_hop_limit configurable
zerodha · Jun 20, 2024 · fa1c1b6 · fa1c1b6
2 parents 76a668e + 4b35674
commit fa1c1b6
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 9 deletions.
diff --git a/modules/nomad-clients/ec2.tf b/modules/nomad-clients/ec2.tf
@@ -24,7 +24,7 @@ resource "aws_instance" "nomad_client" {
 
   metadata_options {
     http_endpoint               = "enabled"
-    http_put_response_hop_limit = 1
+    http_put_response_hop_limit = var.http_put_response_hop_limit
     instance_metadata_tags      = "enabled"
   }
 

diff --git a/modules/nomad-clients/launch_template.tf b/modules/nomad-clients/launch_template.tf
@@ -13,9 +13,10 @@ resource "aws_launch_template" "nomad_client" {
 
   metadata_options {
     http_endpoint               = "enabled"
-    http_put_response_hop_limit = 1
+    http_put_response_hop_limit = var.http_put_response_hop_limit
     instance_metadata_tags      = "enabled"
   }
+
   block_device_mappings {
     device_name = "/dev/sda1"
 

diff --git a/modules/nomad-clients/variables.tf b/modules/nomad-clients/variables.tf
@@ -216,6 +216,12 @@ variable "nomad_client_exec_host_volumes" {
 
 variable "extra_script" {
   description = "Path to custom script to be run as part of cloud-init"
-  type = string
-  default = ""
-}
+  type        = string
+  default     = ""
+}
+
+variable "http_put_response_hop_limit" {
+  description = "The hop limit for HTTP PUT response for the EC2 instance metadata service"
+  type        = number
+  default     = 2
+}
diff --git a/modules/nomad-servers/launch_template.tf b/modules/nomad-servers/launch_template.tf
@@ -12,7 +12,7 @@ resource "aws_launch_template" "nomad_server" {
 
   metadata_options {
     http_endpoint               = "enabled"
-    http_put_response_hop_limit = 1
+    http_put_response_hop_limit = var.http_put_response_hop_limit
     instance_metadata_tags      = "enabled"
   }
 

diff --git a/modules/nomad-servers/variables.tf b/modules/nomad-servers/variables.tf
@@ -177,6 +177,12 @@ variable "nomad_file_limit" {
 
 variable "extra_script" {
   description = "Path to custom script to be run as part of cloud-init"
-  type = string
-  default = ""
-}
+  type        = string
+  default     = ""
+}
+
+variable "http_put_response_hop_limit" {
+  description = "The hop limit for HTTP PUT response for the EC2 instance metadata service"
+  type        = number
+  default     = 2
+}