Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to PCRE2 #52

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Port to PCRE2 #52

wants to merge 3 commits into from

Conversation

bgermann
Copy link

The original PCRE library is deprecated. This is a port to the successor PCRE2.

@bluca
Copy link
Member

bluca commented Apr 20, 2024

Have you tested that this doesn't introduce regressions for the variety of usage of this tool, like those in other repositories in this org?

@bgermann
Copy link
Author

No. Can you point out which ones make use of it? I do not have any gsl domain knowledge.

@bgermann
Copy link
Author

But note that this is incomplete because I do not have the means to adjust and test the Windows build files.

@bluca
Copy link
Member

bluca commented Apr 20, 2024

It is used by https://github.com/zeromq/zproject which in turn is used by a large number of other repos, all those that include a project.xml in the root directory. And yes this needs to be verified on Windows and OSX too at a minimum.

Outside of builds/msvc, replace the pcre references.
Solution: Prevent syntax error by quoting.
@sphaero
Copy link

sphaero commented Apr 20, 2024

Are there any references to differences between the two versions? I couldn't find any when I quickly scanned the PCRE2 github repo.

@bgermann
Copy link
Author

There is no porting guide, but people linked some documentation on the bug which asks for one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants