-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove System.ServiceModel.Primitives dependency. #1017
Open
shanecelis
wants to merge
9
commits into
zeromq:master
Choose a base branch
from
shanecelis:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on May 8, 2022
-
feature: Add ArrayBufferPool implementation.
Add an ArrayPool<byte> from the System.Buffers namespace. With it, one can exclude the System.ServiceModel.Primitives package.
Configuration menu - View commit details
-
Copy full SHA for 1264afb - Browse repository at this point
Copy the full SHA 1264afbView commit details -
feature: Add a build flavor 'Minimal'
In an effort to use NetMQ with Unity3D, one problem was trying to satisfy the dependencies for `System.ServiceModel.Primitives`. It required also providing `System.ServiceModel.{Http,Duplex,NetTcp}` and perhaps more before I gave up. These dependencies were only noticed while Unity3D built the project. When using NetMQ in a regular dotnet project, I've had no problems with the `System.ServiceModel.Primitives` dependencies. I added an alternative implementation of `IBufferPool` using the `ArrayPool` from `System.Buffers` but it is unused. I instrumented the build system to have a "Flavor" that by default is set to "Standard", which changes nothing from before. For my usecase, however, I set the flavor to "Minimal". $ dotnet build -p:Flavor=Minimal This excludes "System.ServiceModel.Primitives" and defines a preprocessor flag of `FLAVOR_MINIMAL` that excludes the BufferManagerBufferPool class and uses the ArrayBufferPool instead.
Configuration menu - View commit details
-
Copy full SHA for 444a1de - Browse repository at this point
Copy the full SHA 444a1deView commit details
Commits on May 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8c87cbc - Browse repository at this point
Copy the full SHA 8c87cbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for f944d62 - Browse repository at this point
Copy the full SHA f944d62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75f916a - Browse repository at this point
Copy the full SHA 75f916aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c8512c - Browse repository at this point
Copy the full SHA 7c8512cView commit details -
chore: Remove System.ServiceModel.Primitives ref.
Subsitute with reference to System.Buffers.
Configuration menu - View commit details
-
Copy full SHA for e412930 - Browse repository at this point
Copy the full SHA e412930View commit details -
feature: Add USE_SERVICE_MODEL define for testing.
I expect the BufferMangerBufferPool implementation will go away but before that happens I wanted the tests for each implementation to remain accessible. If you define USE_SERVICE_MODEL, it will build the old pool implementation and use it. And it'll also run tests against the old and new pool.
Configuration menu - View commit details
-
Copy full SHA for 5a7e7b7 - Browse repository at this point
Copy the full SHA 5a7e7b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for ceef6b9 - Browse repository at this point
Copy the full SHA ceef6b9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.