feat(binding): immediately update the target if the Observable has a BehaviorSubject-like current value member #6
Conversation
…BehaviorSubject-like current value member
| if ("value" in a) { | ||
| binding.originalupdateTarget((a as any).value) | ||
| } else if (typeof (a as any).getValue === "function") { | ||
| binding.originalupdateTarget((a as any).getValue()) |
There was a problem hiding this comment.
does that really make a difference? I mean if you subscribe to a BehaviorSubject the subscription will fire right away with the current value.
|
the request for unit tests was merely to show some use-cases you'd like this addition to handle. Given the above comment I'm not sure what other benefit this could currently have. |
|
Hi Vildan. My apologies for the delay in responding to your request for unit tests. Indeed, the behaviour that you described in your comment (i.e. the I will try and extract a minimal reproduction of this in the coming days. |
|
@james-voth any updates? did you have a chance to look at it again? Quite a while ago though ;) |
Hi Vildan. As the title says, this change ensures that the target is immediately updated if the Observable has a BehaviorSubject-like current value member.