Misc fixes #101
Merged
Misc fixes #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default containing group is the one created earlier in the same file, ie. zig-mode, so we just use that here.
describe-mode already does this
|
Apart from the green CI, the changes also look good to me when testing locally. Thanks a lot! |
|
Great, thanks. |
|
I stopped short of converting the regexps to |
I tried that ~2 years ago when we still supported older Emacsen with reduced |
|
Ah, found what I was talking about: #45 I didn't "give up", it got merged but broke the CI because of limited support for older versions. |
|
Ah nice. I might take a fresh look if I feel in the mood for more random tinkering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw a few small things that warranted tidying up, but just be warned that I've not tested this extensively. Let's see what the CI says.