Add innr SP-242 plug quirk #3896
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quirk for the inner SP-242 plug that updates the MeteringCluster to use the existing MeteringClusterInnr. This adds a divisor for the summed energy usage to report correct usage. Tested in HA as a custom quirk against an SP-242.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3896 +/- ##
=======================================
Coverage 90.95% 90.95%
=======================================
Files 326 327 +1
Lines 10588 10591 +3
=======================================
+ Hits 9630 9633 +3
Misses 958 958 ☔ View full report in Codecov by Sentry. |
TheJulianJES
added
v2 quirk
|
Thanks for the PR! Apparently there were some changes in newer firmware versions that cause issues with our existing quirks, as newer firmware versions now use a different divisor. Reference: Koenkk/zigbee-herdsman-converters#8712 I'll have to come back to this to see how we can fix this for all firmware versions ideally, as not everyone upgrades. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
V2 Quirk for the inner SP-242 plug that updates the MeteringCluster to use the existing MeteringClusterInnr. This adds a divisor for the summed energy usage to report correct usage.
Additional information
Tested in HA as a custom quirk against an SP-242.
Checklist
pre-commitchecks pass / the code has been formatted using Black