Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typing in Tuya classes #3904

Merged
merged 7 commits into from
Feb 26, 2025
Merged

Conversation

TheJulianJES
Copy link
Collaborator

@TheJulianJES TheJulianJES commented Feb 26, 2025

Proposed change

This improves typing in the base Tuya classes.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@TheJulianJES TheJulianJES added Tuya Request/PR regarding a Tuya device code quality Improvement to code quality labels Feb 26, 2025
Otherwise, the zigpy `AddressingMode` type evaluation doesn't work.
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.97%. Comparing base (ff5bf0b) to head (060dccd).
Report is 7 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3904   +/-   ##
=======================================
  Coverage   90.96%   90.97%           
=======================================
  Files         327      327           
  Lines       10608    10611    +3     
=======================================
+ Hits         9650     9653    +3     
  Misses        958      958           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES marked this pull request as ready for review February 26, 2025 02:25
@TheJulianJES TheJulianJES merged commit b87ac89 into zigpy:dev Feb 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improvement to code quality Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant