Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Cover entity handling #376

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from
+612 −214
Open

Improvements to Cover entity handling #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f7281ad
Improvements to Cover PlatformEntity status methods
jeverley Jan 10, 2025
c1085f8
Test coverage for timeout and device instigated movement
jeverley Feb 9, 2025
a96d448
Use common functions for instigating target tracking
jeverley Feb 9, 2025
fb994ff
Calculate axis states only if their position/target has changed
jeverley Feb 9, 2025
f2683cb
Improve debug logging outputs
jeverley Feb 10, 2025
0a4138b
Use CoverState StrEnum in const for states rather than literals
jeverley Feb 10, 2025
6d6e7fa
Readability improvement for _determine_state method
jeverley Feb 10, 2025
9992d3a
Simplify stop_cover methods
jeverley Feb 13, 2025
73d51b7
Fix _attr_device_class for WindowCoveringType.Rollershade
jeverley Feb 13, 2025
f368f06
Amend tests following shade device_class fix
jeverley Feb 13, 2025
d91aea1
Include missing ATTR_CURRENT_TILT_POSITION in state property
jeverley Feb 14, 2025
fd9f968
Docstring updates and use of converter functions for Shade PlatformEn…
jeverley Feb 14, 2025
cbd377a
Guard against state change when target is equal to current position
jeverley Feb 14, 2025
af3aafd
Add test for dynamic movement timeout
jeverley Feb 14, 2025
cc2a967
Full test coverage for tilt axis
jeverley Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/data/devices/ikea-of-sweden-fyrtur-block-out-roller-blind.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@
"platform": "cover",
"class_name": "Cover",
"translation_key": "cover",
"device_class": null,
"device_class": "shade",
"state_class": null,
"entity_category": null,
"entity_registry_enabled_default": true,
Expand Down
2 changes: 1 addition & 1 deletion tests/data/devices/ikea-of-sweden-praktlysing-cellular-blind.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@
"platform": "cover",
"class_name": "Cover",
"translation_key": "cover",
"device_class": null,
"device_class": "shade",
"state_class": null,
"entity_category": null,
"entity_registry_enabled_default": true,
Expand Down
2 changes: 1 addition & 1 deletion tests/data/devices/smartwings-wm25-l-z.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@
"platform": "cover",
"class_name": "Cover",
"translation_key": "cover",
"device_class": null,
"device_class": "shade",
"state_class": null,
"entity_category": null,
"entity_registry_enabled_default": true,
Expand Down
2 changes: 1 addition & 1 deletion tests/data/devices/third-reality-inc-3rsb015bz.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -840,7 +840,7 @@
"platform": "cover",
"class_name": "Cover",
"translation_key": "cover",
"device_class": null,
"device_class": "shade",
"state_class": null,
"entity_category": null,
"entity_registry_enabled_default": true,
Expand Down
2 changes: 1 addition & 1 deletion tests/data/devices/tze200-9caxna4s-ts0301.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@
"platform": "cover",
"class_name": "Cover",
"translation_key": "cover",
"device_class": null,
"device_class": "shade",
"state_class": null,
"entity_category": null,
"entity_registry_enabled_default": true,
Expand Down
2 changes: 1 addition & 1 deletion tests/data/devices/yooksmart-d10110.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@
"platform": "cover",
"class_name": "Cover",
"translation_key": "cover",
"device_class": null,
"device_class": "shade",
"state_class": null,
"entity_category": null,
"entity_registry_enabled_default": true,
Expand Down
Loading
Loading