no string conversion code actions for strings with carriage returns

zigtools · Dec 3, 2024 · 9316eaa · 9316eaa
1 parent d31a391
commit 9316eaa
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/features/code_actions.zig b/src/features/code_actions.zig
@@ -149,7 +149,7 @@ pub fn generateStringLiteralCodeActions(
     };
     // Check for disallowed characters and utf-8 validity
     for (parsed) |c| {
-        if (c == '\n' or c == '\r') continue;
+        if (c == '\n') continue;
         if (std.ascii.isControl(c)) return;
     }
     if (!std.unicode.utf8ValidateSlice(parsed)) return;

diff --git a/tests/lsp_features/code_actions.zig b/tests/lsp_features/code_actions.zig
@@ -807,6 +807,12 @@ test "convert string literal to multiline - invalid" {
     ,
         \\const foo = "\tWe use tabs";
     );
+    // A Multi-Line String Literals can't contain carriage returns
+    try testConvertString(
+        \\const foo = "<cursor>\r";
+    ,
+        \\const foo = "\r";
+    );
     // Not in @import
     try testConvertString(
         \\const std = @import("<cursor>std");