another intern pool rewrite #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techatrix
force-pushed
the
techatrix/intern-pool
branch
from
31e5ca0 to
d81c8a8
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1594 +/- ##
==========================================
- Coverage 76.65% 76.16% -0.49%
==========================================
Files 33 34 +1
Lines 9093 9977 +884
==========================================
+ Hits 6970 7599 +629
- Misses 2123 2378 +255 ☔ View full report in Codecov by Sentry. |
Techatrix
force-pushed
the
techatrix/intern-pool
branch
2 times, most recently
from
04dc75d to
3a6a1cc
Compare
Techatrix
force-pushed
the
techatrix/intern-pool
branch
from
3a6a1cc to
46a4e96
Compare
Techatrix
force-pushed
the
techatrix/intern-pool
branch
from
46a4e96 to
e72a244
Compare
Techatrix
force-pushed
the
techatrix/intern-pool
branch
from
e72a244 to
1b9dd50
Compare
ErrorBuilder: - new `unified` option - new `file_name_visibility` option - new `removeUnusedFiles` function - formatting functions have been rewritten from scratch - tests coverage offsets.zig: - new `offsets.multilineLocAtIndex` function (and wrappers)
- new `StringPool` - most functions now operate on `InternPool.Index` instead of `ÌnternPool.Key` - many new helper functions
Don't worry, it is still going to crash easily (just like ZLS in general)
We may use this in the future to explain types to new Zig users.
- more doc comments - compute string hash before acquiring lock - add safety check for calling deinit while holding lock - add stringToSliceLock - add stringToSlice - remove StringPool.String.empty - remove hashString
Techatrix
force-pushed
the
techatrix/intern-pool
branch
from
9cabd2c to
8391e8f
Compare
covered: - primitives - optionals - pointers - arrays
Techatrix
force-pushed
the
techatrix/intern-pool
branch
5 times, most recently
from
f63109a to
ac3db8d
Compare
Techatrix
force-pushed
the
techatrix/intern-pool
branch
4 times, most recently
from
dfaf542 to
7e39ce5
Compare
Techatrix
force-pushed
the
techatrix/intern-pool
branch
from
7e39ce5 to
7162c33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some work I did on the InternPool from my sema branch.
I decided to do some more changes.
- [ ] improve storage of container typesnah, I will do this another timeI am gonna have so much fun, rebasing my sema branch. (︶︹︶)