node tag .identifier != token tag .identifier, eg @Some

[llogick]

fixes #1645

[SuperAuguste]

This is @Techatrix's worse enemy :P

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5c0bebe) 76.12% compared to head (6170acd) 76.12%.

Files	Patch %	Lines
src/analysis.zig	82.35%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1655   +/-   ##
=======================================
  Coverage   76.12%   76.12%           
=======================================
  Files          34       34           
  Lines       10007    10003    -4     
=======================================
- Hits         7618     7615    -3     
+ Misses       2389     2388    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Techatrix]

Could you add a new test case?

[llogick]

I've felt like reworking identifierTokenToNameSlice and related to do the check(s) and return an error/null every time it has happened and I just might, because it also affects const Self = @This;.

Could you add a new test case?

What would it look like?

[Techatrix]

I've felt like reworking identifierTokenToNameSlice and related to do the check(s) and return an error/null every time it has happened and I just might, because it also affects const Self = @This;.

How about making identifierTokenToNameSlice support zig.tokenizer.Token.Tag.builtin and make it return @This when called on a @This token.

What would it look like?

Convert the code in #1645 into a semantic token test and reduce its size while ensuring that its still hits the assertion.

[llogick]

How about making identifierTokenToNameSlice support zig.tokenizer.Token.Tag.builtin and make it return @This when called on a @This token.

I did consider special casing it in resolveType, but it is an incomplete expr => compile error, and in the case of const Self = @This; it gets passed to lookupSymbolGlobal which is plain wrong.

[Techatrix]

I did consider special casing it in resolveType, but it is an incomplete expr => compile error, and in the case of const Self = @This; it gets passed to lookupSymbolGlobal which is plain wrong.

Then have it return null and adjust the return type?

[llogick]

Then have it return null and adjust the return type?

Which function?

[Techatrix]

identifierTokenToNameSlice and all other variants

[llogick]

identifierTokenToNameSlice and all other variants

I think it's better to be aware that they might fail + code(checks) dedup.

[llogick]

I went with errors, returning null felt vague and forced.