Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect hover support of client when creating signature help #1732

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

Techatrix
Copy link
Member

The client may not support markdown in signature help documentations.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (17befd1) 76.61% compared to head (9f06c08) 76.55%.

Files Patch % Lines
src/Server.zig 20.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1732      +/-   ##
==========================================
- Coverage   76.61%   76.55%   -0.07%     
==========================================
  Files          34       34              
  Lines        9985     9997      +12     
==========================================
+ Hits         7650     7653       +3     
- Misses       2335     2344       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@llogick llogick merged commit 63f5ad1 into master Jan 30, 2024
12 checks passed
@llogick llogick deleted the techatrix/signature-help-markup-kind branch January 30, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants