Skip to content

Commit

Permalink
update
Browse files Browse the repository at this point in the history
Signed-off-by: cqy123456 <[email protected]>
  • Loading branch information
cqy123456 committed Dec 12, 2023
1 parent 6084153 commit 1cbb332
Show file tree
Hide file tree
Showing 14 changed files with 286 additions and 365 deletions.
47 changes: 24 additions & 23 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
# Copyright (C) 2019-2023 Zilliz. All rights reserved.
#Copyright(C) 2019 - 2023 Zilliz.All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not
# use this file except in compliance with the License. You may obtain a copy of
# the License at
#Licensed under the Apache License, Version 2.0(the "License"); you may not
#use this file except in compliance with the License.You may obtain a copy of
#the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#http: // www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations under
# the License
#Unless required by applicable law or agreed to in writing, software
#distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
#WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.See the
#License for the specific language governing permissions and limitations under
#the License

cmake_minimum_required(VERSION 3.26.4 FATAL_ERROR)
project(knowhere CXX C)
Expand Down Expand Up @@ -39,18 +39,18 @@ knowhere_option(WITH_CCACHE "Build with ccache" ON)
knowhere_option(WITH_PROFILER "Build with profiler" OFF)
knowhere_option(WITH_FAISS_TESTS "Build with Faiss unit tests" OFF)

# this is needed for clang on ubuntu:20.04, otherwise
# the linked fails with 'undefined reference' error.
# fmt v9 was used by the time the error was encountered.
# clang on ubuntu:22.04 seems to be unaffected.
# gcc seems to be unaffected.
#this is needed for clang on ubuntu : 20.04, otherwise
#the linked fails with 'undefined reference' error.
#fmt v9 was used by the time the error was encountered.
#clang on ubuntu : 22.04 seems to be unaffected.
#gcc seems to be unaffected.
add_definitions(-DFMT_HEADER_ONLY)

# this is needed for clang on ubuntu:20.04, otherwise
# the linked fails with 'undefined reference' error.
# fmt v9 was used by the time the error was encountered.
# clang on ubuntu:22.04 seems to be unaffected.
# gcc seems to be unaffected.
#this is needed for clang on ubuntu : 20.04, otherwise
#the linked fails with 'undefined reference' error.
#fmt v9 was used by the time the error was encountered.
#clang on ubuntu : 22.04 seems to be unaffected.
#gcc seems to be unaffected.
add_definitions(-DFMT_HEADER_ONLY)

if(KNOWHERE_VERSION)
Expand All @@ -64,9 +64,10 @@ if(WITH_CCACHE)
message(STATUS "Using ccache: ${CCACHE_FOUND}")
set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE ${CCACHE_FOUND})
set_property(GLOBAL PROPERTY RULE_LAUNCH_LINK ${CCACHE_FOUND})
# let ccache preserve C++ comments, because some of them may be meaningful
# to the compiler
set(ENV{CCACHE_COMMENTS} "1")
#let ccache preserve C++ comments, because some of them may be meaningful
#to the compiler
set(ENV{
CCACHE_COMMENTS} "1")
endif()
endif()

Expand Down
46 changes: 25 additions & 21 deletions LICENSE
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,11 @@
use, offer to sell, sell, import, and otherwise transfer the Work,
where such license applies only to those patent claims licensable
by such Contributor that are necessarily infringed by their
Contribution(s) alone or by combination of their Contribution(s)
with the Work to which such Contribution(s) was submitted. If You
Contribution(s)
alone or by combination of their
Contribution(s)
with the Work to which such
Contribution(s) was submitted. If You
institute patent litigation against any entity (including a
cross-claim or counterclaim in a lawsuit) alleging that the Work
or a Contribution incorporated within the Work constitutes direct
Expand All @@ -92,25 +95,26 @@
meet the following conditions:

(a) You must give any other recipients of the Work or
Derivative Works a copy of this License; and

(b) You must cause any modified files to carry prominent notices
stating that You changed the files; and

(c) You must retain, in the Source form of any Derivative Works
that You distribute, all copyright, patent, trademark, and
attribution notices from the Source form of the Work,
excluding those notices that do not pertain to any part of
the Derivative Works; and

(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file, excluding those notices that do not
pertain to any part of the Derivative Works, in at least one
of the following places: within a NOTICE text file distributed
as part of the Derivative Works; within the Source form or
documentation, if provided along with the Derivative Works; or,
Derivative Works a copy of this License;
and

(b) You must cause any modified files to carry prominent notices stating that You
changed the files;
and

(c) You must retain,
in the Source form of any Derivative Works that You distribute, all copyright,
patent, trademark, and attribution notices from the Source form of the Work,
excluding those notices that do not pertain to any part of the Derivative Works;
and

(d) If the Work includes a "NOTICE" text file as part of its distribution,
then any Derivative Works that You distribute must include a readable copy of the
attribution notices contained within such NOTICE file,
excluding those notices that do not pertain to any part of the Derivative Works,
in at least one of the following places
: within a NOTICE text file distributed as part of the Derivative Works;
within the Source form or documentation, if provided along with the Derivative Works; or,
within a display generated by the Derivative Works, if and
wherever such third-party notices normally appear. The contents
of the NOTICE file are for informational purposes only and
Expand Down
38 changes: 9 additions & 29 deletions OWNERS
Original file line number Diff line number Diff line change
@@ -1,32 +1,12 @@
filters:
".*":
reviewers:
- cydrain
- xiaofan-luan
- liliu-z
- Presburger
- foxspy
- hhy3
- PwzXxm
- cqy123456
- zhengbuqian
- chasingegg
filters : ".*" : reviewers : -cydrain - xiaofan - luan - liliu - z - Presburger - foxspy - hhy3 - PwzXxm - cqy123456 -
zhengbuqian -
chasingegg

approvers:
- cydrain
- xiaofan-luan
- liliu-z
- Presburger
- foxspy
- hhy3
- PwzXxm
- cqy123456
- zhengbuqian
- chasingegg
approvers
: -cydrain -
xiaofan - luan - liliu - z - Presburger - foxspy - hhy3 - PwzXxm - cqy123456 - zhengbuqian -
chasingegg

"tests":
reviewers:
- yanliang567
"tests" : reviewers : -yanliang567

approvers:
- yanliang567
approvers : -yanliang567
49 changes: 16 additions & 33 deletions codecov.yml
Original file line number Diff line number Diff line change
@@ -1,36 +1,19 @@
# Configuration File for CodeCov
codecov:
require_ci_to_pass: no
notify:
require_ci_to_pass: no
wait_for_ci: false
ci:
- jenkins.milvus.io:18080
coverage:
precision: 2
round: down
range: "50...100"
#Configuration File for CodeCov
codecov : require_ci_to_pass : no notify : require_ci_to_pass : no wait_for_ci : false ci
: -jenkins.milvus.io : 18080 coverage : precision : 2 round : down range : "50...100"

status:
project:
default:
target: 50%
threshold: 0% #Allow the coverage to drop by threshold%, and posting a success status.
patch:
default:
target: 60% #target of patch diff
threshold: 0%
if_ci_failed: error #success, failure, error, ignore
status : project : default
: target : 50 %
threshold : 0 % #Allow the coverage to drop by threshold %
,
and posting a success status.patch : default : target : 60 % #target of patch diff threshold : 0 %
if_ci_failed : error #success,
failure, error,
ignore

comment:
layout: "reach, diff, flags, files"
behavior: default
require_changes: false
branches: # branch names that can post comment
- main
comment : layout : "reach, diff, flags, files" behavior : default require_changes : false branches
: #branch names that can post comment -
main

ignore:
- "LICENSES"
- ".git"
- "*.yml"
- "*.md"
ignore : -"LICENSES" -
".git" - "*.yml" - "*.md"
Loading

0 comments on commit 1cbb332

Please sign in to comment.