Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sparse: set the default value of refine_factor to 1 #1033

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sparknack
Copy link
Contributor

Because of the removal of forward index, the current refine searching is slower than before. To prevent performance degradation when using a non-zero value of drop_ratio_search, set the default value of refine_factor to 1.

@sre-ci-robot sre-ci-robot requested review from hhy3 and liliu-z January 15, 2025 16:07
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sparknack
To complete the pull request process, please assign pwzxxm after the PR has been reviewed.
You can assign the PR to them by writing /assign @pwzxxm in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

mergify bot commented Jan 15, 2025

@sparknack 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Because of the removal of forward index, the current refine searching is
slower than before. To prevent performance degradation when using a
non-zero value of drop_ratio_search, set the default value of
refine_factor to 1.

Signed-off-by: Shawn Wang <[email protected]>
@sparknack sparknack changed the title sparse: make the default value of refine_factor to 1 sparse: set the default value of refine_factor to 1 Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.49%. Comparing base (3c46f4c) to head (74baa01).
Report is 291 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #1033       +/-   ##
=========================================
+ Coverage      0   73.49%   +73.49%     
=========================================
  Files         0       82       +82     
  Lines         0     7488     +7488     
=========================================
+ Hits          0     5503     +5503     
- Misses        0     1985     +1985     

see 82 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants