Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The final candidate of the version that uses Faiss 1.7.4 #181

Merged

Conversation

alexanderguzhva
Copy link
Collaborator

@alexanderguzhva alexanderguzhva commented Nov 6, 2023

Finalized version of #90
Based on Faiss 1.7.4 (based on commit c8d6f7bb2b09b8928570222131353f75acb4007b from Sep 6 2023, but with all the most recent merged commits).

Issue #186

The following changes were made to Knowhere besides refactoring:

  • All BitsetView filtering is replaced with faiss::IDSelector filtering.
  • So-called “thread-safe” functions were deleted. Instead, regular search()/range_search() are used with faiss::SearchParameters objects as a function parameter.
  • faiss::elkan_L2_sse() call is used by default as before, but IVF-indices in Knowhere (ivf.cc) introduce a new flag “use_elkan” (false by default), which allows to significantly speed up the training

/kind enhancement

Copy link

mergify bot commented Nov 6, 2023

@alexanderguzhva 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@zhengbuqian
Copy link
Collaborator

/lgtm

Thanks Alex!
Looked at files in directory other than thirdparty/faiss.

@liliu-z
Copy link
Collaborator

liliu-z commented Nov 7, 2023

/approve

Plz resolve the conflicts and link an issue with this PR. Thanks~

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@chasingegg chasingegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot merged commit f7fd047 into zilliztech:main Nov 9, 2023
7 checks passed
@liliu-z
Copy link
Collaborator

liliu-z commented Nov 9, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants