Merge CheckAndAdjust APIs #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liliu-z The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/kind enhancement |
|
@liliu-z 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
Instead of having many APIs for different `PARAM_TYPE`, Knowhere's Config operations(Load/Check) are using a single API with `PARAM_TYPE` as a parameter. However, the post loading APIs (CheckAndAdjustForXXX) didn't follow this rule. This PR synced this style. Signed-off-by: Li Liu <[email protected]>
liliu-z
force-pushed
the
modify_config
branch
from
928bbdb to
60da3a9
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having many APIs for different
PARAM_TYPE, Knowhere's Config operations(Load/Check) are using a single API withPARAM_TYPEas a parameter. However, the post loading APIs (CheckAndAdjustForXXX) didn't follow this rule. This PR synced this style.issue: #206